fix: workflow tool visibility consistency across all SDKs#11
Merged
msilverblatt merged 2 commits intomasterfrom Mar 15, 2026
Merged
fix: workflow tool visibility consistency across all SDKs#11msilverblatt merged 2 commits intomasterfrom
msilverblatt merged 2 commits intomasterfrom
Conversation
…ock before handler - TypeScript and Go workflow terminal case now computes disableTools (all tools not in pre-workflow set) instead of returning empty array - Rust compute_transition now disables ALL non-allowed tools, not just workflow tools, so block_during rules are properly enforced - Rust handle_step_call drops ACTIVE_WORKFLOW lock before calling the step handler to prevent deadlock if handler accesses workflow state
- Go and TypeScript cancel handlers now compute disableTools (was empty) - Go workflow initial step now computes preWorkflowTools from registered tools when ToolManagerAdapter.GetActiveTools is nil (the common case)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Final workflow tool-visibility consistency fixes. All 4 SDKs now match Python's reference behavior for enable/disable on terminal completion, error transitions, and cancel.
Changes
disableToolsas all registered tools NOT in the pre-workflow set (was returning empty array, leaving workflow step tools callable after completion)compute_transition: Now disables ALL non-allowed tools, not just workflow tools. External tools matchingblock_duringrules are now properly hidden during transitions.handle_step_call: DropsACTIVE_WORKFLOWmutex before calling step handler to prevent deadlock if handler accesses workflow stateTest plan