fix: reload hang, workflow visibility, and comprehensive test coverage#9
Merged
msilverblatt merged 2 commits intomasterfrom Mar 15, 2026
Merged
fix: reload hang, workflow visibility, and comprehensive test coverage#9msilverblatt merged 2 commits intomasterfrom
msilverblatt merged 2 commits intomasterfrom
Conversation
- Python/TypeScript reload now sends post-reload tool list with empty request_id so the Go runtime routes it correctly (fixes reload hang) - Go SDK resource template matching checks URI before calling handler - TypeScript workflow computes disableTools on transitions (was empty) - TypeScript workflow awaits async step handlers (was dropping Promises) - Go SDK workflow returns enable/disable lists via ToolResult instead of relying on nil ToolManagerAdapter
Python (21 new tests): - Hidden tool detection includes workflow/group hidden tools - Resource template URI matching patterns - Hot reload clears all registries TypeScript (5 new tests): - Workflow preWorkflowTools snapshot and restore - Hot reload registry clearing - Hidden tool detection across sources Go SDK (4 new tests): - HiddenHint option behavior Rust (2 new tests): - Hidden field defaults and construction E2E (4 new tests): - Python resource read - Python prompt get - Python tool call echo + add verification
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes hot reload hanging in Python/TypeScript, workflow tool visibility across all SDKs, and adds 36 new tests including e2e coverage for resources and prompts.
Bug fixes
request_idinstead of empty. The Go runtime routes non-empty IDs topendingchannels, but the reload channel was already consumed — so the tool list was silently dropped and reload timed out. Fixed by sending with emptyrequest_id.handleReadResourcecalled every template handler without checking if the URI matched the template pattern. AddeduriMatchesTemplateguard.disableToolsalways empty: Non-terminal transitions only enabled new step tools but never disabled old ones. Now computes the full disable set.stepDef.handler()was not awaited, so async handlers returned"[object Promise]".transitionToStepsrelied on a nilToolManagerAdapter. Refactored to return tools via ToolResult.New tests (36 total)
Test plan