Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had repaired the tests in RunFabilandTest so that they deterministically passed on my local machine. However, on the build server they failed. Inspection of the output revealed that, in the matsim plans that came from silo and entered in the year one matsim simulation, some of the persons had other home location coordinates. Presumably, the
Movesmodel was not deterministic in the sense that it produced different results on different machines. I did the following:TransportModelPropertiesModule.TravelTimeImplIdentifier.MATSIM. I thus switched off the multi-threading completely in that class; if someone wants to be able to switch it on by a separate parameter, please go ahead and add the corresponding code.