Land Norgate volume reconstruction + schema-v2 promotion on main#11
Merged
Conversation
…sors) Deliberate, versioned promotion of the additive reconstruction columns to a usable default — kept separate from the additive commit so the default-changing step is visible, not silent. - get_prices(volume="front"|"reconstructed"): "front" (default) is byte-identical to the pre-v2 API; "reconstructed" serves reconstructed-with-per-row-raw-fallback in Volume plus a Volume_Source audit column. The fallback policy lives once, in the data layer, instead of being re-derived at every consumer call site. - schema_version()/require_schema(): expose the manifest schema so consumers key cache invalidation on a real token instead of a column-presence heuristic. - SCHEMA_VERSION 1 -> 2. Store is not actually v2 until a full producer pass re-writes it; see docs/plan_promote_reconstructed_volume.md for rollout order. - README schema note; tests for the view, fallback, and schema guard (31 passed). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Promote reconstructed volume via schema v2 (intent view + accessors)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the full Norgate volume reconstruction + schema-v2 promotion feature on
main. These changes have been sitting onfeat/norgate-volume-reconstruction(PR #10 merged the promotion into this branch, not into main), somainstill hasSCHEMA_VERSION = 1and novolume=/schema_version()API.The consumers are already on their mains and depend on this API:
cotdata.get_prices(volume='reconstructed')andcotdata.schema_version().main↔ consumermainis inconsistent — a fresh checkout/install of cotdatamainbreaks both consumers (get_prices()has novolume=kwarg;schema_versiondoesn't exist).Merging this restores consistency.
What's in it (3 commits)
Volume_Reconstructed/Volume_Source).get_prices(volume="front"|"reconstructed")intent view,schema_version()/require_schema(),SCHEMA_VERSION1 → 2, docs + tests (31 passed).After merge
Run a full
norgate.update()producer pass (Windows) to re-write the store somanifest.jsonactually carriesschema_version: 2. Until thenschema_version()reads 1 and consumers behave exactly as pre-v2 (safe).🤖 Generated with Claude Code