fix: add circular dependency detection at build time#5
Merged
Conversation
Detect cycles in the dependency graph during ContainerBuilder.build() using depth-first search. Raises CircularDependencyError with the full cycle path (e.g., "A → B → C → A") for easy debugging. Handles direct cycles (A → B → A), indirect cycles (A → B → C → A), self-references (A → A), and correctly allows diamond patterns.
- Add pre-alpha warning to documentation index - Fix all code examples to use async/await and async context managers - Add documentation for lifecycle hooks (initializer, finalizer) - Add documentation for autowire parameter - Remove references to non-existent exceptions (TypeResolutionError, InstantiationError) - Fix toctree order to follow Diátaxis (tutorials, how-to, explanation, reference) - Update error handling section to reflect actual exceptions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContainerBuilder.build()using DFSCircularDependencyErrorwith full cycle path (e.g., "A → B → C → A")await,async with)Fixes #1
Changes
Circular Dependency Detection
_check_circular_dependencies()Documentation Fixes
await container.get()andasync with container.scope()initializer,finalizer, andautowireparametersTest Plan