refactor(test): remove redundant undefined#339
Closed
noritaka1166 wants to merge 1 commit intomswjs:mainfrom
Closed
refactor(test): remove redundant undefined#339noritaka1166 wants to merge 1 commit intomswjs:mainfrom
noritaka1166 wants to merge 1 commit intomswjs:mainfrom
Conversation
Member
|
Hi, @noritaka1166. Appreciate the suggestion here, but that In our case, we want to match three things:
I believe the current type tests capture these scenarios well. Let me know if I missed anything. Otherwise, I will close this pull request. |
Contributor
Author
|
@kettanaito |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove redundant undefined in test