Migrate the :breach-server event.#8600
Merged
NoahTheDuke merged 1 commit intomtgred:masterfrom Mar 9, 2026
Merged
Conversation
…ty Grid was an issue, so it was refactored to avoid hidding those errors again.
Collaborator
|
Thanks for doing this! every bit helps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following some instructions given to be my NoahTheDuke in chat I have migrated the
:breach-serverevent to use the new context map system. This was not the most interesting example of it (with only one argument) but the pattern works.Although not required the implementation of Mwanza City Grid made this change harder, but obscuring which maps where connected to which events, so I inlined those assoc calls to make it more obvious. It also saved some lines of code.