Open
Conversation
…ad for the accessibility of the site at 200% zoom on small viewports and doesn't really seem to gain us anything
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Theme components for a new "pretty article" content type (eventually possibly just the regular article), including paragraph types for banner and resource panel.
Future Work
If you copy/paste HTML code that inserts a FontAwesome icon into CKEditor 5 text areas and save the page, you'll be unable to edit it again without disabling JavaScript – for some reason, the combination of CKEditor 5 + edit + FontAwesome tags in content boxes (not FontAwesome-specific fields) + JavaScript takes over the CPU (I have seen as high as 300% in the task manager in Chrome) and the browser locks up.
Disabling JavaScript, removing the tag, and saving the node restores the ability to edit with JavaScript enabled. 🤷♀️
:thanksIHateIt:
Testing
Describe how the tester could verify that this branch works. Did you add any automated tests?
To be completed by the person testing