Pass CTRL + C to the currently running adb command, if any#26
Open
veeti wants to merge 1 commit into
Open
Conversation
Allows exiting logcat and repeating loop situations (multiple devices connected and no device selected) without killing Replicant itself. GitHub: fixes mttkay#24
Owner
|
Sorry missed this. Will review over the weekend. Meanwhile, it looks like the build is failing? |
Owner
|
I got around to testing this, but it's not working well for me. In fact, I get the reverse effect now: while CTRL+C-ing out of an ADB command seems to work, when doing the same with built in interactive commands like This needs more work before I can merge it back. |
Owner
|
As to your question about I'd be open for suggestions though if such things can be achieved in a simpler way, i.e. by not creating a custom command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows exiting logcat and repeating loop situations (multiple devices
connected and no device selected) without killing Replicant itself.
GitHub: fixes #24