Skip to content

Pass CTRL + C to the currently running adb command, if any#26

Open
veeti wants to merge 1 commit into
mttkay:masterfrom
veeti:interrupt
Open

Pass CTRL + C to the currently running adb command, if any#26
veeti wants to merge 1 commit into
mttkay:masterfrom
veeti:interrupt

Conversation

@veeti

@veeti veeti commented Dec 9, 2013

Copy link
Copy Markdown
Contributor

Allows exiting logcat and repeating loop situations (multiple devices
connected and no device selected) without killing Replicant itself.

GitHub: fixes #24

Allows exiting logcat and repeating loop situations (multiple devices
connected and no device selected) without killing Replicant itself.

GitHub: fixes mttkay#24
@mttkay

mttkay commented Dec 13, 2013

Copy link
Copy Markdown
Owner

Sorry missed this. Will review over the weekend. Meanwhile, it looks like the build is failing?

@mttkay

mttkay commented Dec 28, 2013

Copy link
Copy Markdown
Owner

I got around to testing this, but it's not working well for me. In fact, I get the reverse effect now: while CTRL+C-ing out of an ADB command seems to work, when doing the same with built in interactive commands like !logcat, it immediately exits replicant.

This needs more work before I can merge it back.

@mttkay

mttkay commented Dec 28, 2013

Copy link
Copy Markdown
Owner

As to your question about !logcat: it adds logic on top of adb logcat such as filtering by process ID of the active package by default. There's an open issue to evolve it further, like colorizing log output, see #3

I'd be open for suggestions though if such things can be achieved in a simpler way, i.e. by not creating a custom command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem exiting logcat

2 participants