[l10n] Add missing MuiPagination localization to zh-CN locale#48741
Open
greymoth-jp wants to merge 1 commit into
Open
[l10n] Add missing MuiPagination localization to zh-CN locale#48741greymoth-jp wants to merge 1 commit into
greymoth-jp wants to merge 1 commit into
Conversation
Deploy previewBundle size
Check out the code infra dashboard for more information about this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
zh-CNlocale is missing theMuiPaginationblock, so its paginationaria-labeland thegetItemAriaLabeltext fall back to English even though every other component in the file is localized.MuiPagination(aria-labelplusgetItemAriaLabel) is part of the canonical localizable set documented inenUS.ts, and almost every locale file already provides it. The only ones that don't are the three Chinese locales (zh-CN,zh-HK,zh-TW); for comparisonja-JPandko-KRboth localize this block already. So this looks like a copy-paste gap rather than an intentional omission.This PR fills it in for
zh-CN. For the first/last/next/previous and page wording I reused the noun phrases already present in this file'sMuiTablePagination.getItemAriaLabel(第一页 / 最后一页 / 下一页 / 上一页) and added 转到 ("Go to") so it matches the English source, which marks every navigable item with "Go to" and leaves the current page unmarked.Note: the same block is also absent from
zh-HKandzh-TW. I left those out here since the Traditional Chinese wording differs and I would rather not guess at it. Happy to follow up if you want them covered too.