Skip to content

Converting ymmsl to markdown scripts#2

Merged
IrisvdWerf merged 24 commits intomainfrom
ymmsl-to-markdown
Feb 20, 2026
Merged

Converting ymmsl to markdown scripts#2
IrisvdWerf merged 24 commits intomainfrom
ymmsl-to-markdown

Conversation

@IrisvdWerf
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks nice! I haven't tested it though :)

I have a couple of comments, see below. Let me know if you have any questions!

@maarten-ic maarten-ic self-requested a review February 18, 2026 15:26
Copy link
Copy Markdown
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed: can you

  • Update the user-documentation: add an example yMMSL (in docs/examples) and include it in the generated docs
  • Add a couple of unit tests

Let me know if anything's unclear!

@IrisvdWerf IrisvdWerf marked this pull request as ready for review February 19, 2026 15:19
Copy link
Copy Markdown
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks nice, thanks! Couple of comments on the generated documentation:

Copy link
Copy Markdown
Collaborator

@maarten-ic maarten-ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@IrisvdWerf IrisvdWerf merged commit 7874f81 into main Feb 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants