do not WARN if no state change found for SCR tx#141
Merged
BeniaminDrasovean merged 3 commits intoMar 17, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces log noise by downgrading the log level from Warn to Trace when no state accesses are found for Smart Contract Result (SCR) transactions. A new TxType enum is introduced to tag each transaction in the pool with its type, enabling the differentiated logging behavior.
Changes:
- Added a
TxTypeenum and tagged eachtxWithOrderentry with its transaction type (Transaction, SCR, Reward, InvalidTx). - Refactored
getTxsWithOrderto build the slice directly instead of going through an intermediate map, also preserving the tx type. - Changed the missing state-accesses log: SCRs now log at
Tracelevel; other types still log atWarnlevel (now includingtxType).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
miiu96
approved these changes
Mar 17, 2026
ssd04
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.