Skip to content

do not WARN if no state change found for SCR tx#141

Merged
BeniaminDrasovean merged 3 commits into
rc/supernovafrom
state-changes-WARN-pollution-fix
Mar 17, 2026
Merged

do not WARN if no state change found for SCR tx#141
BeniaminDrasovean merged 3 commits into
rc/supernovafrom
state-changes-WARN-pollution-fix

Conversation

@BeniaminDrasovean

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces log noise by downgrading the log level from Warn to Trace when no state accesses are found for Smart Contract Result (SCR) transactions. A new TxType enum is introduced to tag each transaction in the pool with its type, enabling the differentiated logging behavior.

Changes:

  • Added a TxType enum and tagged each txWithOrder entry with its transaction type (Transaction, SCR, Reward, InvalidTx).
  • Refactored getTxsWithOrder to build the slice directly instead of going through an intermediate map, also preserving the tx type.
  • Changed the missing state-accesses log: SCRs now log at Trace level; other types still log at Warn level (now including txType).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread process/eventsInterceptor.go Outdated
@BeniaminDrasovean BeniaminDrasovean merged commit 126b339 into rc/supernova Mar 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants