Conversation
There was a problem hiding this comment.
Pull request overview
This PR prepares the SDK for the "supernova release" by introducing several changes to support new network features and improve transaction handling.
Changes:
- Added millisecond-precision block timestamp support via new
blockTimestampMsfield - Reduced default polling timeout from 6000ms to 600ms across account and transaction watchers
- Added support for "not-executable-in-block" transaction status as a failed state
- Consolidated timeout constants from hardcoded values to centralized constants
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/networkProviders/networkStatus.ts | Added blockTimestampMs field for millisecond timestamp precision |
| src/networkProviders/constants.ts | Reduced account polling timeout from 6000ms to 600ms |
| src/core/transactionWatcher.ts | Refactored to use centralized constants instead of hardcoded timeout values |
| src/core/transactionWatcher.spec.ts | Added test coverage for "not-executable-in-block" status |
| src/core/transactionStatus.ts | Added "not-executable-in-block" as a failed transaction status |
| src/core/constants.ts | Defined new transaction awaiting timeout constants |
| package.json | Bumped version to 15.4.0 |
| package-lock.json | Updated version lockfile to 15.4.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mradian1
previously approved these changes
Feb 2, 2026
AdoAdoAdo
reviewed
Feb 10, 2026
src/core/transactionStatus.ts
Outdated
There was a problem hiding this comment.
Is this correct for the unexecutable to be reported as failed?
this was not executed, similar to higher nonce or lower nonce in transaction.
It may be executed in a different block afterwards (for higher nonce for example, if the gap is filled)
AdoAdoAdo
approved these changes
Feb 10, 2026
mradian1
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.