Skip to content

refactor: use gorich/helperr instead of internal/sclerr#10

Merged
murfffi merged 3 commits intomainfrom
tests/gorich
Sep 28, 2025
Merged

refactor: use gorich/helperr instead of internal/sclerr#10
murfffi merged 3 commits intomainfrom
tests/gorich

Conversation

@murfffi
Copy link
Owner

@murfffi murfffi commented Sep 28, 2025

use gorich/helperr instead of internal/sclerr;
also refresh deps

@gemini-code-assist
Copy link

Summary of Changes

Hello @murfffi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the project's error handling by migrating from a custom internal utility to a standardized external library, gorich/helperr. Concurrently, it updates several Go module dependencies, ensuring the project benefits from the latest features and bug fixes.

Highlights

  • Refactor Error Handling: The internal sclerr package has been replaced with the external gorich/helperr library for CloseQuietly functionality, standardizing error handling utilities.
  • Dependency Updates: Several Go module dependencies, including github.com/ansel1/merry/v2 and github.com/stretchr/testify, have been updated to their latest versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the codebase to use gorich/helperr instead of the internal sclerr package for quietly closing resources, and also updates other dependencies. The change is a simple replacement, but the use of CloseQuietly on file writers introduces risks of silent failures and data corruption. I've identified two instances in download/download.go where this is problematic and provided feedback for safer error handling.

@murfffi murfffi merged commit fd8e8b3 into main Sep 28, 2025
2 checks passed
@murfffi murfffi deleted the tests/gorich branch September 28, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant