Skip to content

tests: add checks, coverage to pipeline#12

Merged
murfffi merged 1 commit intomainfrom
tests/checks
Sep 30, 2025
Merged

tests: add checks, coverage to pipeline#12
murfffi merged 1 commit intomainfrom
tests/checks

Conversation

@murfffi
Copy link
Owner

@murfffi murfffi commented Sep 30, 2025

No description provided.

Also optimizes pipeline to run only short tests in alternative configurations
@gemini-code-assist
Copy link

Summary of Changes

Hello @murfffi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly strengthens the project's development and CI/CD pipeline by integrating a robust Makefile that automates and standardizes testing, code coverage analysis, and various code quality checks. The changes aim to improve the overall reliability, maintainability, and security of the codebase by ensuring consistent application of best practices and early detection of potential issues.

Highlights

  • Enhanced Testing Pipeline: A new Makefile has been introduced, centralizing and automating various testing and code quality checks. This includes a comprehensive test target that runs Go tests with race detection, atomic coverage, verbose output, vet checks, and a timeout.
  • Code Coverage Reporting: The new test target is configured to collect and process Go test coverage data, generating both a human-readable HTML report and a text format suitable for external services like Coveralls.
  • Automated Code Quality Checks: A checks target has been added, which orchestrates several critical code quality tools: govulncheck for vulnerability scanning, go mod tidy verification to ensure module consistency, and modernize for applying Go code modernization suggestions.
  • Gitignore Update: The .gitignore file has been updated to reflect a change in the name of a local executable to be ignored, from duckdb.exe to getaduck.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/go.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a Makefile to standardize testing, linting, and other checks, and updates the .gitignore file. The new Makefile is comprehensive and adds valuable automation for ensuring code quality. I've identified a critical issue with the lint command that will prevent it from running, and a couple of medium-severity issues related to external dependencies and maintainability in the test and check_modern targets. My suggestions aim to make the build pipeline more robust and portable.

@murfffi murfffi merged commit 366f566 into main Sep 30, 2025
2 checks passed
@murfffi murfffi deleted the tests/checks branch September 30, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant