Skip to content

feat: overwrite support in CLI#14

Merged
murfffi merged 1 commit intomainfrom
feat/cli_overwrite
Oct 8, 2025
Merged

feat: overwrite support in CLI#14
murfffi merged 1 commit intomainfrom
feat/cli_overwrite

Conversation

@murfffi
Copy link
Owner

@murfffi murfffi commented Oct 8, 2025

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @murfffi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request adds a new feature to the command-line interface (CLI) allowing users to specify whether existing files should be overwritten during download operations. It introduces an --overwrite flag and updates the output logging to provide clearer feedback based on the overwrite behavior.

Highlights

  • New Feature: Introduced an --overwrite flag in the CLI to control whether existing files should be overwritten during download operations.
  • User Feedback: Improved logging messages to clearly indicate if a file was downloaded or if it already existed and was not overwritten.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@murfffi murfffi merged commit 9b92ba7 into main Oct 8, 2025
2 checks passed
@murfffi murfffi deleted the feat/cli_overwrite branch October 8, 2025 14:28
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces an overwrite flag to the CLI, which is a useful feature. The implementation is straightforward. My main concern, detailed in the review comment, is about the default value of this new flag, which I believe is unsafe.

version := fs.String("version", spec.Version, "DuckDB version")
binOS := fs.String("os", spec.OS, "target OS")
binArch := fs.String("arch", spec.Arch, "target architecture")
binOverwrite := fs.Bool("overwrite", true, "overwrite existing file")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The default value for the overwrite flag is set to true. This is a potentially destructive default, as it could lead to users accidentally overwriting files. It's standard practice for operations that can overwrite data to be opt-in.

The default should be false to prevent accidental data loss. The user can then explicitly enable it by passing -overwrite or -overwrite=true.

Suggested change
binOverwrite := fs.Bool("overwrite", true, "overwrite existing file")
binOverwrite := fs.Bool("overwrite", false, "overwrite existing file")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant