Skip to content

fix: handle arm64/aarch64 difference before and after 1.3#8

Merged
murfffi merged 1 commit intomainfrom
fix/armname
Sep 16, 2025
Merged

fix: handle arm64/aarch64 difference before and after 1.3#8
murfffi merged 1 commit intomainfrom
fix/armname

Conversation

@murfffi
Copy link
Owner

@murfffi murfffi commented Sep 16, 2025

No description provided.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @murfffi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a crucial fix for handling arm64 architecture naming conventions that changed around version 1.3. It ensures that older versions correctly map arm64 to aarch64 while newer versions use arm64 directly. The changes also include version string normalization and a substantial expansion of test cases to thoroughly validate the new logic across different versions and architectures, alongside minor Go module updates.

Highlights

  • Platform Architecture Handling: Implemented logic to correctly map arm64 to aarch64 only for versions prior to v1.3.0, addressing a change in how these architectures are referenced in different versions. For versions v1.3.0 and above, arm64 is now used directly.
  • Version Normalization: Added a step to normalize version strings by prepending 'v' if a version is semver-valid without it, ensuring consistent version comparisons using the golang.org/x/mod/semver package.
  • Expanded Test Coverage: Significantly enhanced the download tests to cover various versions and architectures, including arm64, to thoroughly validate the new architecture handling logic across different version scenarios.
  • Dependency Updates: Updated the Go module to go 1.24.7 and introduced golang.org/x/mod as a new dependency for semantic versioning utilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with architecture name differences for arm64 in DuckDB versions prior to v1.3.0 by conditionally changing arm64 to aarch64. It also improves version string handling by automatically prepending v where appropriate. The test suite has been significantly expanded to cover various versions and architectures, which is a great improvement. My review includes a couple of suggestions to enhance code maintainability by replacing a magic string with a constant and by refactoring the new test to use a table-driven approach for better readability.

@murfffi murfffi merged commit 66e9844 into main Sep 16, 2025
2 checks passed
@murfffi murfffi deleted the fix/armname branch September 16, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant