Conversation
|
This is still not working correctly. 
1. Bend set to 3/4 in the Properties panel: draws as 1 1/4 in the score.
2. Bend set to 1/4 in the Properties panel: draws as 3/4 in the score.
3. Switch to standard staff type. Result: Expected 1/4 bend is drawn in score, but has changed to 3/4 in the properties panel.
4. Set the bend interval to 1/4, and notice that spacing changes slightly, although the drawn accidental doesn't change.
5. Change back to TAB staff. Both score and properties panel show 3/4 bend where 1/4 is expected.
|
mike-spa
force-pushed
the
fixQuarterToneBendOnTab
branch
from
73d99ea to
324b952
Compare
src/engraving/dom/guitarbend.h
Outdated
|
|
||
| enum class QuarterOffset : unsigned char { | ||
| QUARTER_FLAT, | ||
| enum class QuarterOffset { |
There was a problem hiding this comment.
| enum class QuarterOffset { | |
| enum class QuarterOffset : signed char { |
| break; | ||
| case ElementType::ACCIDENTAL: | ||
| m_accidental = toAccidental(e); | ||
| m_centOffset = Accidental::subtype2centOffset(toAccidental(e)->accidentalType()); |
There was a problem hiding this comment.
Is it worth changing all existing usage of Accidental::subtype2centOffset to use the note's centOffset property now? eg. in Note::playingTuning and TLayout::layoutNoteAnchoredLine?
There was a problem hiding this comment.
Almost certainly yes, but I'd rather do that after the release so that we keep these changes as confined as possible for now
miiizen
left a comment
miiizen
left a comment
There was a problem hiding this comment.
Looks good! Also glad we're making a step in the right direction for better tuning support
|
There is still a problem changing staff type. 
1. Set bend interval to 1/4.
2. Switch to standard staff. RESULT: a regular semitone accidental is drawn, not the expected microtonal accidental.
3. Undo _Set staff type_. RESULT: The bend has been changed to 1/2.
Note: This only seems to happen when switching from TAB to standard staff type - not vice versa. I.e., explicitly setting a microtonal bend on a standard staff and switching to TAB appears to be working correctly. |
It's unnecessary and not general enough now that we have centOffset corrections
4 participants
Resolves: #31109
UPDATE. Microtonal bends work based on microtonal accidentals. If there is at least one notation staff, the information about accidentals propagates to TAB staff too. But if there isn't, TAB staves don't support any accidental logic, therefore microtonal bends don't work. This PR adds the "cent offset" information to notes themselves (as opposed to just inferring it from the accidental) which is anyway a necessary step to support microtonal music in future.