Integration and sample links#26
Integration and sample links#26davy7125 wants to merge 3 commits intomusescore:masterfrom davy7125:master
Conversation
Integration improvement (fix #11): * preprocessor variable to loose the xml and libsnd dependencies * namespace SfTools * smallSf now a class variable * C++11 not needed anymore (struct initialization) * dynamic declaration of array now ok with visual C++ (fix #10) * warning and unused variables removed Bug fix: * sample links now kept in the soundfont (fix #9)
Now possible to convert back from sf3 to sf2 (option y) Soundfont 2.04 can be converted also (sm24 chunk was rejected) The attenuation before compressing is stored as a comment in the ogg data so that the attenuation can be reverted when uncompressing it Adapted the documentation
|
The conversion tool can now convert back from sf3 to sf2 (fix #22) |
Fix a bug: the iver and irom don't stop the conversion
| creator = 0; | ||
| product = 0; | ||
| copyright = 0; | ||
| } |
There was a problem hiding this comment.
You changed the indentation of everything.
The new indentation is also not the MuseScore indentation style (which is a bit weird, but at least consistently used in MuseScore-related code).
There was a problem hiding this comment.
I'm sorry for that I began to edit the files inside my project and I am used to automatically indent files. You could still reopen the files with an IDE or some advanced text editor for reindenting them.
There was a problem hiding this comment.
This makes the diff illegible and therefore impossible to review, though.
There was a problem hiding this comment.
I will not blame you if this pull request is closed without being integrated ;-)
The code is working in Polyphone, that's what I wanted
|
Davy Triponney dixit:
I will not blame you if this pull request is closed without being
integrated ;-)
But I will blame you… I very much *do* want these
fixes and even new features to be merged.
|
|
Hmm, if we have a chance to get this relicenced, maybe there’s a chance you can clean this up (to use the MuseScore coding style to keep the diff legible) so it can be considered for inclusion, and rebase the version in Polyphone on the latest sftools one then? |
2 participants
Integration improvement (fix #11):
Bug fix: