Conversation
Add OGG stream type to enums for audio formats.. The reason is a user is streaming from an icecast server. It is being sent in OGG format with metadata in standard Ogg tags that get updated with each new track. Assuming we wnt to support this then the first step is to add this new streamtype and once that is in the new code path to support this will be added to core
Replaced OGG stream type with IN_BAND stream type in enums.
OzGav
changed the title
Updated the comment for IN_BAND to clarify its purpose.
|
|
||
| # in_band: radio stream with in-band metadata | ||
| # (e.g. ogg vorbis comments, flac metadata blocks, opus tags) | ||
| IN_BAND = "in_band" |
There was a problem hiding this comment.
This feels a bit weird as its not a stream type but more a behavior of the stream.
How are you seeing this ? Is this going to be processed differently ?
There was a problem hiding this comment.
I was thinking of doing the same as we did for shoutcast so once this type is identified this is set and it allows a dedicated code path for handling? So this is about supporting metadata in radio streams. Originally I was going to call it just OGG but then discovered FLAC and Opus support this as well.
There was a problem hiding this comment.
So, we are talking about stream type here (not content type) so OGG or any other codec would be wrong
There was a problem hiding this comment.
Yeah fair enough. Yes we are talking about a stream type that has metadata embedded in tags within it (distinct from ICY or SHOUTCAST). It could be FLAC, OGG, or OPUS codec
There was a problem hiding this comment.
Here is the PR for the actual application of this music-assistant/server#3326
2 participants
Add IN_BAND stream type for audio formats that carry metadata inside the container (e.g. Ogg Vorbis comments, FLAC metadata blocks, Opus tags). For example, there are Icecast servers streaming in OGG format with metadata in standard Ogg tags that update with each new track.