Fix queue state loss on player re-register#3352
Merged
MarvinSchenkel merged 4 commits intodevfrom Mar 10, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an edge case where a player that disconnects/unregisters and later re-registers could resume with stale internal queue comparison/transition state, leading to stuck queues or incorrect track progression.
Changes:
- Clear
_prev_statesentries for a queue when its player is removed from the registry. - Remove the queue from
_transitioning_playerswhen the player is removed, preventing stale “transition in progress” gating on re-register.
Member
Author
|
Partially superseded #3340 |
MarvinSchenkel
approved these changes
Mar 10, 2026
Contributor
MarvinSchenkel
left a comment
MarvinSchenkel
left a comment
There was a problem hiding this comment.
Nice, thanks @maximmaxim345 🙏
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
* fix: clear queue transient state on player unregister * Remove redundant comments * fix: cancel queued play_index timer on player removal
MarvinSchenkel
pushed a commit
that referenced
this pull request
Mar 12, 2026
* fix: clear queue transient state on player unregister * Remove redundant comments * fix: cancel queued play_index timer on player removal
ALERTua
pushed a commit
to ALERTua/fork_music_assistant_server
that referenced
this pull request
Mar 12, 2026
* fix: clear queue transient state on player unregister * Remove redundant comments * fix: cancel queued play_index timer on player removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes queues getting lost for players that get re-registered.
Particularly fixes the Sendspin Web Player loosing its queue.