Fix Sendspin playback stability issues#3382
Merged
MarvinSchenkel merged 7 commits intomusic-assistant:devfrom Mar 16, 2026
Merged
Fix Sendspin playback stability issues#3382MarvinSchenkel merged 7 commits intomusic-assistant:devfrom
MarvinSchenkel merged 7 commits intomusic-assistant:devfrom
Conversation
When the producer finishes in a sync group with DSP players, ffmpeg transform processes still hold the last few samples in their internal buffers. Without an explicit EOF signal, `readexactly` in the commit task blocks forever waiting for output that will never come, preventing cleanup and leaving the player stuck in "playing" state.
Contributor
🔒 Dependency Security Report📦 Modified Dependencies
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets Sendspin playback reliability by updating the Sendspin client library and hardening the provider’s group membership reconciliation + DSP playback pipeline to reduce race conditions during rapid group changes and end-of-track transitions.
Changes:
- Bump
aiosendspinto4.3.4(both global requirements and provider manifest). - Coalesce/abort duplicate membership reconciliation tasks in the Sendspin player event handlers.
- Improve Sendspin playback session join/catchup lifecycle and ensure ffmpeg pipelines are flushed on EOF; stop only the active stream instance.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| requirements_all.txt | Updates pinned aiosendspin version to 4.3.4. |
| music_assistant/providers/sendspin/manifest.json | Updates provider requirements pin to aiosendspin==4.3.4. |
| music_assistant/providers/sendspin/player.py | Coalesces group membership reconciliation via a debounced task. |
| music_assistant/providers/sendspin/playback.py | Adds EOF flushing for ffmpeg processors, adjusts join/catchup lifecycle, and stops the correct stream instance. |
MarvinSchenkel
approved these changes
Mar 16, 2026
Contributor
MarvinSchenkel
left a comment
There was a problem hiding this comment.
LGTM, thanks @maximmaxim345
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several race conditions could cause Sendspin players to get stuck, immediately pause, or get out of sync, especially under rapid group membership changes and when DSP was enabled.
aiosendspin 4.3.4
Bumps aiosendspin to 4.3.4 which include these fixes:
Sendspin Provider fixes