Conversation
Adds the Dashie player provider for Music Assistant, enabling Android
tablets running the Dashie app to appear as MA players with full
playback control, volume, and metadata display.
Provider changes (music_assistant/providers/dashie/):
- Renamed from dashie_kiosk to dashie
- Poll-based player with 3s interval for state sync
- Pushes track metadata to device via REST API
- Supports play/pause, next, previous, stop, volume_set
- Manual IP configuration for devices not auto-discovered via HA
Streams controller additions:
- /player_state/{queue_id} and /player_state (active queue) endpoints
- /players endpoint listing available MA players with friendly names
- /recently_played/{queue_id} endpoint
- Extended serve_command_request with volume_set, previous, play,
pause, play_pause, stop commands
- Friendly name derivation from entity IDs
- Elapsed time clamping with min() instead of modulo
Code quality:
- Response type validation in client
- Debug-level logging for routine operations
- Extracted _get_ma_server_url() helper to deduplicate
- Consistent error handling across all endpoints
🔒 Dependency Security Report✅ No dependency changes detected in this PR. |
There was a problem hiding this comment.
Can you explain to me why all these changes are needed? The streamscontroller is meant to handle streaming related actions only. You should not have to worry about this when developing a player plugin and changes to this file should not be necessary.
Could you explain what functionality you require in your player provider so that I can steer you in the right direction? The endpoints you register in the streamscontroller don't even seem to be used in the player provider?
MarvinSchenkel
left a comment
MarvinSchenkel
left a comment
There was a problem hiding this comment.
Please have a look at my comment about the streamscontroller and mark this PR as ready for review when you want us to have another look.
|
@jwlerch78 Can you confirm that Dashie has the same functionality as Fully Kiosk per the linked table? I need to add this as a new column |
3 participants
Summary
Apologies for the incremental review request so quickly. I didn't realize there was a dev server and hadn't thoroughly tested the last release. This one is tested and working well.
This PR adds the Dashie player provider for Music Assistant, enabling Android tablets running the Dashie family dashboard app to appear as MA players with full playback control, volume, and metadata display. It also adds several streams server endpoints needed for the integration.
Provider (
music_assistant/providers/dashie/)dashie_kiosktodashiesetMediaInfo)Streams controller additions
/player_state/{queue_id}and/player_state(active queue) endpoints/playersendpoint listing available MA players with friendly names/recently_played/{queue_id}endpointserve_command_requestwithvolume_set,previous,play,pause,play_pause,stopcommands_friendly_name()derives readable names from entity IDs_get_player_state()extracted to avoid code duplicationmin()instead of modulo{"error": str(err)}with status 500Test plan
volume_setcommand working/player_stateendpoint returns correct state/playersendpoint lists all available players with friendly names🤖 Generated with Claude Code