Skip to content

Auto-created pull request into develop from feature/release-notes-test #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mvallim merged 1 commit into from
Jun 20, 2026
+13 −4
Merged

Auto-created pull request into develop from feature/release-notes-test #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...b-template/src/main/java/com/amazon/sns/messaging/lib/core/AbstractAmazonSnsConsumer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,6 +301,11 @@ private Optional<R> createBatch(final BlockingQueue<RequestEntry<E>> requests) {
final String message = String.format("The maximum allowed message size exceeding 256KB (262,144 bytes). Payload: %s, Headers: %s", stringPayload, request.getMessageHeaders());

handleError(publishBatchRequest, new MaximumAllowedMessageException(message, requests.take()));

// This entry was rejected and already removed from the queue above; its size
// must NOT be folded into batchSizeBytes, or it would wrongly cut the batch
// short even when smaller, valid entries are still waiting right behind it.
continue;
}

if (canAddPayload(batchSizeBytes.addAndGet(messageSize))) {
Expand Down
4 changes: 3 additions & 1 deletion ...saging-lib-template/src/main/java/com/amazon/sns/messaging/lib/core/ListenableFuture.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

package com.amazon.sns.messaging.lib.core;

import static java.util.function.Function.identity;

import java.util.function.Consumer;

import com.amazon.sns.messaging.lib.model.ResponseFailEntry;
Expand Down Expand Up @@ -45,7 +47,7 @@ public interface ListenableFuture<S, F> {
* @param successCallback the callback to invoke on success
*/
default void addCallback(final Consumer<? super S> successCallback) {
addCallback(successCallback, result -> { });
addCallback(successCallback, identity()::apply);
}

/**
Expand Down
8 changes: 5 additions & 3 deletions ...ng-lib-template/src/main/java/com/amazon/sns/messaging/lib/core/ListenableFutureImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,10 @@

package com.amazon.sns.messaging.lib.core;

import static java.util.function.Function.identity;

import java.util.LinkedList;
import java.util.Objects;
import java.util.Optional;
import java.util.Queue;
import java.util.function.Consumer;

Expand Down Expand Up @@ -54,8 +56,8 @@ class ListenableFutureImpl implements ListenableFuture<ResponseSuccessEntry, Res
@Override
public void addCallback(final Consumer<? super ResponseSuccessEntry> successCallback, final Consumer<? super ResponseFailEntry> failureCallback) {
synchronized (mutex) {
final Consumer<? super ResponseSuccessEntry> success = Objects.nonNull(successCallback) ? successCallback : result -> { };
final Consumer<? super ResponseFailEntry> failure = Objects.nonNull(failureCallback) ? failureCallback : result -> { };
final Consumer<? super ResponseSuccessEntry> success = Optional.ofNullable(successCallback).orElse(identity()::apply);
final Consumer<? super ResponseFailEntry> failure = Optional.ofNullable(failureCallback).orElse(identity()::apply);

switch (state) {
case NEW:
Expand Down
Loading