drop use of libudev in favour of udevadm output parsing#12
Open
drop use of libudev in favour of udevadm output parsing#12
Conversation
Using libudev makes the packaging more complicated (now we need to ship libudev in the snap) and is also not really needed because we do not use any of the dynamic niceness of libudev. We just use it to detect removable devices which we can equally well do with the output of udevadm. So instead of using a cool and small cgo based libgudev wrapper we go back to good old text parsing.
prologic
approved these changes
Nov 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using libudev makes the packaging more complicated (now we need
to ship libudev in the snap) and is also not really needed because
we do not use any of the dynamic niceness of libudev. We just use
it to detect removable devices which we can equally well do with
the output of udevadm.
So instead of using a cool and small cgo based libgudev wrapper
we go back to good old text parsing.