Reimplement menu and toolbar with GActions#164
Merged
mvo5 merged 1 commit intomvo5:masterfrom Jan 26, 2026
Merged
Conversation
andy128k
force-pushed
the
menu-actions
branch
from
85b2cd3 to
4fdcc21
Compare
mvo5
reviewed
Jan 21, 2026
Owner
mvo5
left a comment
mvo5
left a comment
There was a problem hiding this comment.
Thanks! This is extremly nice! I did not had time to play with it to really test it but I really appreciate your work on this! After a quick test I will mege
|
|
||
| if (_config->FindB("Volatile::startInRepositories", false)) { | ||
| mainWindow->cbShowSourcesWindow(NULL, mainWindow); | ||
| mainWindow->cbShowSourcesWindow(NULL, NULL, mainWindow); |
Owner
There was a problem hiding this comment.
(super nitpick) I wonder if we should move these to nullptr too?
| assert(_win); | ||
|
|
||
| const GActionEntry entries[] = { | ||
| { "read-markings", cbOpenClicked }, |
| { | ||
| RGMainWindow *me = (RGMainWindow *) data; | ||
| assert(me); | ||
| // callback same as for install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for Gtk4