Skip to content

Refactor/organize root files#80

Open
mvoof wants to merge 2 commits into
mainfrom
refactor/organize-root-files
Open

Refactor/organize root files#80
mvoof wants to merge 2 commits into
mainfrom
refactor/organize-root-files

Conversation

@mvoof

@mvoof mvoof commented Jun 16, 2026

Copy link
Copy Markdown
Owner

No description provided.

mvoof added 2 commits June 16, 2026 23:38
…/typescript/

  Split tree_parser/ by language domain: Rust parsers go to parser/rust/,
  TypeScript/JS parsers go to parser/typescript/. Rename file_processor
  to pipeline to reflect its role in the data flow. Backward-compatible
  re-exports in lib.rs keep all tests passing without changes.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the internal module structure of the LSP server, organizing source files into more structured directories such as discovery, parser (with rust and typescript submodules), and pipeline. It also updates imports and sets up backward-compatible aliases in lib.rs. However, a compilation issue was identified in lsp-server/src/main.rs because moving scanner inside the discovery module breaks absolute path references like crate::scanner in other submodules. Re-exporting scanner at the root using pub(crate) use will resolve this compilation error.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lsp-server/src/main.rs
mod utils;

use crate::discovery::config_reader;
use crate::discovery::scanner;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The submodule lsp-server/src/discovery/config_reader.rs references crate::scanner::find_tauri_config using an absolute path. Since scanner was moved inside the discovery module and is no longer declared as a root module in main.rs, compiling the binary crate will fail because crate::scanner cannot be resolved.

Changing this import to pub(crate) use re-exports scanner at the root of the binary crate, resolving the compilation error.

pub(crate) use crate::discovery::scanner;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant