Skip to content

aw/fix-privacy-policy #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ash-wright123 merged 1 commit into from
Jan 21, 2026
Merged

aw/fix-privacy-policy #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/views/disclosure/Disclosure.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { getSize } from 'src/redux/selectors/Browser'

import { PageviewInfo } from 'src/const/Analytics'
import useAnalyticsPath from 'src/hooks/useAnalyticsPath'
import { __, _p } from 'src/utilities/Intl'
import { __, _p, getLocale } from 'src/utilities/Intl'
import { fadeOut } from 'src/utilities/Animation'

import { SlideDown } from 'src/components/SlideDown'
Expand Down Expand Up @@ -63,7 +63,10 @@ export const Disclosure = React.forwardRef((_, disclosureRef) => {
>
{showPrivacyPolicy ? (
<SlideDown delay={getNextDelay()}>
<PrivacyPolicy onCancel={() => setShowPrivacyPolicy(false)} />
<PrivacyPolicy
onCancel={() => setShowPrivacyPolicy(false)}
showExternalLinkPopup={showExternalLinkPopup}
/>
</SlideDown>
) : (
<Fragment>
Expand Down Expand Up @@ -160,7 +163,12 @@ export const Disclosure = React.forwardRef((_, disclosureRef) => {
scrollToTop(containerRef)
setShowPrivacyPolicy(true)
} else {
goToUrlLink('https://www.mx.com/privacy/', true)
const locale = getLocale()
const privacyUrl =
locale === 'fr-ca'
? 'https://www.mx.com/fr/privacy/'
: 'https://www.mx.com/privacy/'
goToUrlLink(privacyUrl, true)
}
}}
style={styles.link}
Expand Down
16 changes: 13 additions & 3 deletions src/views/disclosure/Interstitial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import { Link, Stack } from '@mui/material'
import { PageviewInfo } from 'src/const/Analytics'

import useAnalyticsPath from 'src/hooks/useAnalyticsPath'
import { __, _p } from 'src/utilities/Intl'
import { __, _p, getLocale } from 'src/utilities/Intl'
import { goToUrlLink } from 'src/utilities/global'

import { SlideDown } from 'src/components/SlideDown'
Expand Down Expand Up @@ -64,7 +64,12 @@ export const DisclosureInterstitial = React.forwardRef((props, interstitialNavRe
}

if (currentView === VIEWS.PRIVACY_POLICY) {
return <PrivacyPolicy onCancel={() => setCurrentView(VIEWS.INTERSTITIAL_DISCLOSURE)} />
return (
<PrivacyPolicy
onCancel={() => setCurrentView(VIEWS.INTERSTITIAL_DISCLOSURE)}
showExternalLinkPopup={showExternalLinkPopup}
/>
)
} else if (currentView === VIEWS.DATA_REQUESTED) {
return <DataRequested setCurrentView={setCurrentView} />
} else if (currentView === VIEWS.AVAILABLE_DATA) {
Expand Down Expand Up @@ -180,7 +185,12 @@ export const DisclosureInterstitial = React.forwardRef((props, interstitialNavRe
scrollToTop()
setCurrentView(VIEWS.PRIVACY_POLICY)
} else {
goToUrlLink('https://www.mx.com/privacy/', true)
const locale = getLocale()
const privacyUrl =
locale === 'fr-ca'
? 'https://www.mx.com/fr/privacy/'
: 'https://www.mx.com/privacy/'
goToUrlLink(privacyUrl, true)
}
}}
style={styles.link}
Expand Down
Loading