Fix C# discriminator enum naming to include package prefix#279
Draft
Fix C# discriminator enum naming to include package prefix#279
Conversation
…t with C++/TypeScript) Co-authored-by: rijesha <7819200+rijesha@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update implementation for message enumeration in C#
Fix C# discriminator enum naming to include package prefix
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
C# was generating
field_orderoneof discriminator enums without the package prefix, inconsistent with regular C# enums, C++, and TypeScript which all include it.Before:
After (matching C++/TypeScript):
Changes
csharp_gen.py: Fixed 5 call sites ofget_discriminator_enum_name()/generate_discriminator_enum()to pass the fullstructName({package}{MessageName}) instead of baremsg.name. Affected locations: field declaration, deserialization, field-order dispatch, envelope methods, and file generation.tests/proto/test_messages.proto: AddedSimplePayload(no msgid) andUnionTestMessageFieldOrder(msgid=212) to exercise thefield_orderdiscriminator path — a case previously absent from the test suite.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.