Fix: Rename commands interface for React Native 0.81+ compatibility#5
Merged
Fix: Rename commands interface for React Native 0.81+ compatibility#5
Conversation
Fixes #4 React Native 0.81+ requires the commands interface to follow specific naming conventions for Fabric codegen. Renaming PencilKitCommands to NativeCommands resolves the "No command found with setTool" error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4
Renames the commands interface from
PencilKitCommandstoNativeCommandsto comply with Fabric codegen naming conventions in React Native 0.81+.Problem
Users upgrading to React Native 0.81+ encountered "No command found with setTool" errors when calling imperative methods like
showToolPicker()andsetTool().Solution
React Native's Fabric codegen requires specific naming patterns for native commands interfaces. Renaming
PencilKitCommandstoNativeCommandsensures proper code generation and command registration.Changes
PencilKitCommandsinterface toNativeCommandsCommandsexport to use the new interface nameTest Plan
showToolPicker()hideToolPicker()setTool()clear()undo()redo()