Skip to content

Fix: Handle duplicate style keys after trimming in ParseStyle#416

Merged
mysticmind merged 1 commit intomysticmind:masterfrom
med-khalil:fix/parse-style-duplicate-keys
Feb 24, 2026
Merged

Fix: Handle duplicate style keys after trimming in ParseStyle#416
mysticmind merged 1 commit intomysticmind:masterfrom
med-khalil:fix/parse-style-duplicate-keys

Conversation

@med-khalil
Copy link
Contributor

Fixes a bug where style attributes with duplicate keys (after trimming spaces) would throw a duplicate key exception.

Changes: Trim key-value pairs before DistinctBy to prevent false duplicates, add case-insensitive comparer to DistinctBy for proper deduplication, add converter test to verify the fix

@med-khalil med-khalil force-pushed the fix/parse-style-duplicate-keys branch from 6d45573 to e03593e Compare February 11, 2026 15:18
@med-khalil med-khalil marked this pull request as draft February 11, 2026 15:19
@med-khalil med-khalil force-pushed the fix/parse-style-duplicate-keys branch from e03593e to 8b09324 Compare February 11, 2026 15:24
Fixes a bug where style attributes with duplicate keys (after trimming spaces) would throw a duplicate key exception.

Changes: Trim key-value pairs before DistinctBy to prevent false duplicates, add case-insensitive comparer to DistinctBy for proper deduplication, add converter test to verify the fix
@med-khalil med-khalil force-pushed the fix/parse-style-duplicate-keys branch from 8b09324 to 0e4116c Compare February 11, 2026 15:27
@med-khalil med-khalil marked this pull request as ready for review February 11, 2026 15:27
@mysticmind mysticmind added this to the 5.1 milestone Feb 24, 2026
@mysticmind mysticmind merged commit 64a50c0 into mysticmind:master Feb 24, 2026
1 check passed
@mysticmind
Copy link
Owner

Thanks for the PR @med-khalil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants