Skip to content

Update browser-chat Cargo.lock to use iroh 0.97 instead of 0.96.1#159

Merged
matheus23 merged 1 commit inton0-computer:mainfrom
rectalogic:locks
Mar 23, 2026
Merged

Update browser-chat Cargo.lock to use iroh 0.97 instead of 0.96.1#159
matheus23 merged 1 commit inton0-computer:mainfrom
rectalogic:locks

Conversation

@rectalogic
Copy link
Copy Markdown
Contributor

I expect this will cause the wasm browser-chat build to fail because it seems like iroh 0.97 pulls in rustls-ring and rustls unconditionally. Also iroh-relay 0.97 pulls in rustls-ring and tokio-rustls with ring unconditionally. And ring fails to compile for wasm.

@n0bot n0bot bot added this to iroh Mar 20, 2026
@github-project-automation github-project-automation bot moved this to 🚑 Needs Triage in iroh Mar 20, 2026
@rectalogic
Copy link
Copy Markdown
Contributor Author

rectalogic commented Mar 20, 2026

Yeah, building for wasm fails with iroh 0.97. Something is broken with iroh dependencies I think:

$ cd browser-chat
$ cargo build -p chat-browser --target wasm32-unknown-unknown
   Compiling proc-macro2 v1.0.106
   Compiling unicode-ident v1.0.24
   Compiling quote v1.0.45
   Compiling rustversion v1.0.22
   Compiling cfg-if v1.0.4
   Compiling wasm-bindgen-shared v0.2.114
   Compiling once_cell v1.21.4
   Compiling bumpalo v3.20.2
   Compiling serde_core v1.0.228
   Compiling serde v1.0.228
   Compiling pin-project-lite v0.2.17
   Compiling futures-core v0.3.32
   Compiling typenum v1.19.0
   Compiling memchr v2.8.0
   Compiling futures-sink v0.3.32
   Compiling futures-io v0.3.32
   Compiling futures-channel v0.3.32
   Compiling semver v1.0.27
   Compiling cfg_aliases v0.2.1
   Compiling slab v0.4.12
   Compiling futures-task v0.3.32
   Compiling stable_deref_trait v1.2.1
   Compiling itoa v1.0.18
   Compiling rustc_version v0.4.1
   Compiling anyhow v1.0.102
   Compiling find-msvc-tools v0.1.9
   Compiling shlex v1.3.0
   Compiling version_check v0.9.5
   Compiling cc v1.2.57
   Compiling log v0.4.29
   Compiling getrandom v0.3.4
   Compiling generic-array v0.14.7
   Compiling libc v0.2.183
   Compiling subtle v2.6.1
   Compiling ident_case v1.0.1
   Compiling strsim v0.11.1
   Compiling fnv v1.0.7
   Compiling zmij v1.0.21
   Compiling smallvec v1.15.1
   Compiling serde_json v1.0.149
   Compiling const-oid v0.10.2
   Compiling unicode-segmentation v1.12.0
   Compiling tracing-core v0.1.36
   Compiling writeable v0.6.2
   Compiling wasm-bindgen v0.2.114
   Compiling litemap v0.8.1
   Compiling thiserror v2.0.18
   Compiling convert_case v0.10.0
   Compiling unicode-xid v0.2.6
   Compiling hybrid-array v0.4.8
   Compiling icu_normalizer_data v2.1.1
   Compiling icu_properties_data v2.1.2
   Compiling base64ct v1.8.3
   Compiling percent-encoding v2.3.2
   Compiling syn v2.0.117
   Compiling form_urlencoded v1.2.2
   Compiling pem-rfc7468 v1.0.0
   Compiling crypto-common v0.1.7
   Compiling ring v0.17.14
   Compiling zerocopy v0.8.47
   Compiling crypto-common v0.2.1
   Compiling block-buffer v0.11.0
   Compiling fastrand v2.3.0
   Compiling inout v0.1.4
   Compiling vergen-lib v9.1.0
   Compiling curve25519-dalek v5.0.0-pre.1
   Compiling digest v0.11.0-rc.10
   Compiling untrusted v0.9.0
   Compiling parking v2.2.1
   Compiling ryu v1.0.23
   Compiling futures-lite v2.6.1
   Compiling cipher v0.4.4
   Compiling universal-hash v0.5.1
   Compiling vergen-lib v0.1.6
   Compiling vergen v9.1.0
   Compiling heapless v0.7.17
   Compiling n0-future v0.3.2
   Compiling spin v0.10.0
   Compiling signature v3.0.0-rc.10
   Compiling equivalent v1.0.2
   Compiling rustls v0.23.37
   Compiling hashbrown v0.16.1
   Compiling powerfmt v0.2.0
   Compiling cordyceps v0.3.4
   Compiling send_wrapper v0.6.0
   Compiling utf8_iter v1.0.4
   Compiling libm v0.2.16
   Compiling opaque-debug v0.3.1
   Compiling winnow v1.0.0
   Compiling byteorder v1.5.0
   Compiling diatomic-waker v0.2.3
   Compiling futures-buffered v0.2.13
   Compiling hash32 v0.2.1
   Compiling indexmap v2.13.0
   Compiling polyval v0.6.2
warning: ring@0.17.14: error: unable to create target: 'No available targets are compatible with triple "wasm32-unknown-unknown"'
warning: ring@0.17.14: 1 error generated.
error: failed to run custom build command for `ring v0.17.14`

Caused by:
  process didn't exit successfully: `/Users/aw/Projects/rectalogic/iroh-git/iroh-examples/browser-chat/target/debug/build/ring-21a0d75c44651cfc/build-script-build` (exit status: 1)
  --- stdout
  cargo:rerun-if-env-changed=CARGO_MANIFEST_DIR
  cargo:rerun-if-env-changed=CARGO_PKG_NAME
  cargo:rerun-if-env-changed=CARGO_PKG_VERSION_MAJOR
  cargo:rerun-if-env-changed=CARGO_PKG_VERSION_MINOR
  cargo:rerun-if-env-changed=CARGO_PKG_VERSION_PATCH
  cargo:rerun-if-env-changed=CARGO_PKG_VERSION_PRE
  cargo:rerun-if-env-changed=CARGO_MANIFEST_LINKS
  cargo:rerun-if-env-changed=RING_PREGENERATE_ASM
  cargo:rerun-if-env-changed=OUT_DIR
  cargo:rerun-if-env-changed=CARGO_CFG_TARGET_ARCH
  cargo:rerun-if-env-changed=CARGO_CFG_TARGET_OS
  cargo:rerun-if-env-changed=CARGO_CFG_TARGET_ENV
  cargo:rerun-if-env-changed=CARGO_CFG_TARGET_ENDIAN
  cargo:rerun-if-env-changed=CC_wasm32-unknown-unknown
  CC_wasm32-unknown-unknown = None
  cargo:rerun-if-env-changed=CC_wasm32_unknown_unknown
  CC_wasm32_unknown_unknown = None
  cargo:rerun-if-env-changed=TARGET_CC
  TARGET_CC = None
  cargo:rerun-if-env-changed=CC
  CC = None
  cargo:rerun-if-env-changed=CC_ENABLE_DEBUG_OUTPUT
  cargo:rerun-if-env-changed=CRATE_CC_NO_DEFAULTS
  CRATE_CC_NO_DEFAULTS = None
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:rerun-if-env-changed=TARGET_CFLAGS
  TARGET_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS_wasm32_unknown_unknown
  CFLAGS_wasm32_unknown_unknown = None
  cargo:rerun-if-env-changed=CFLAGS_wasm32-unknown-unknown
  CFLAGS_wasm32-unknown-unknown = None
  cargo:warning=error: unable to create target: 'No available targets are compatible with triple "wasm32-unknown-unknown"'
  cargo:warning=1 error generated.

  --- stderr


  error occurred in cc-rs: command did not execute successfully (status code exit status: 1): LC_ALL="C" "clang" "-O0" "-ffunction-sections" "-fdata-sections" "-fno-exceptions" "-g" "-fno-omit-frame-pointer" "--target=wasm32-unknown-unknown" "-I" "/Users/aw/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ring-0.17.14/include" "-I" "/Users/aw/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ring-0.17.14/pregenerated" "-Wall" "-Wextra" "-fvisibility=hidden" "-std=c1x" "-Wall" "-Wbad-function-cast" "-Wcast-align" "-Wcast-qual" "-Wconversion" "-Wmissing-field-initializers" "-Wmissing-include-dirs" "-Wnested-externs" "-Wredundant-decls" "-Wshadow" "-Wsign-compare" "-Wsign-conversion" "-Wstrict-prototypes" "-Wundef" "-Wuninitialized" "-g3" "-nostdlibinc" "-DNDEBUG" "-DRING_CORE_NOSTDLIBINC=1" "-o" "/Users/aw/Projects/rectalogic/iroh-git/iroh-examples/browser-chat/target/wasm32-unknown-unknown/debug/build/ring-564a73a5b31f734b/out/25ac62e5b3c53843-curve25519.o" "-c" "/Users/aw/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/ring-0.17.14/crypto/curve25519/curve25519.c"


warning: build failed, waiting for other jobs to finish...

@rectalogic rectalogic changed the title Update browser-chat Cargo.lock to use iroh 0.96.1 instead of 0.97 Update browser-chat Cargo.lock to use iroh 0.97 instead of 0.96.1 Mar 21, 2026
@rectalogic
Copy link
Copy Markdown
Contributor Author

OK, it builds on macos with this:

PATH=(brew --prefix llvm)/bin:$PATH RUSTFLAGS='--cfg getrandom_backend="wasm_js"' cargo build --target wasm32-unknown-unknown -p chat-browser

But the Cargo.lock still should be updated from iroh 0.97 to 0.97

@matheus23
Copy link
Copy Markdown
Member

Thank you for this.

I thought we've already updated all Cargo.toml iroh dependencies to 0.97 in #155, so we should not have any iroh 0.96.1 dependencies in the cargo lock anymore.
Is this branch based on the latest version of the example repo?
Or did the PR above just not update the lockfile?

@rectalogic
Copy link
Copy Markdown
Contributor Author

Thank you for this.

I thought we've already updated all Cargo.toml iroh dependencies to 0.97 in #155

#155 did update browser-chat/Cargo.lock to iroh 0.97, but then subsequent PR #156 downgraded it to 0.96.0, and then subsequent PR #157 to that upgraded it to 0.96.1.

This PR upgrades it from 0.96.1 to 0.97

Copy link
Copy Markdown
Member

@matheus23 matheus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. @rklaehn I guess we should be more careful with lockfile changes!

Thank you for the PR!

@matheus23 matheus23 merged commit 82f48be into n0-computer:main Mar 23, 2026
17 checks passed
@github-project-automation github-project-automation bot moved this from 🚑 Needs Triage to ✅ Done in iroh Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants