chore(deps): Update rand and friends to version 0.10#3922
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3922/docs/iroh/ Last updated: 2026-03-30T15:46:20Z |
Contributor
|
wasm failures, your favorite |
Member
Author
|
@dignifiedquire did you intentionally close this? And if so, why? 😅 |
|
@dignifiedquire was this actually meant to be closed |
Contributor
|
no, though we might need to wait until all deps are properly updated |
|
ty bossman |
matheus23
force-pushed
the
matheus23/rand-0.10
branch
from
89e95cf to
14858bc
Compare
Member
Author
|
(moved this TODO list into the PR description) |
This was referenced Mar 18, 2026
jgrund
reviewed
Mar 19, 2026
Member
Author
|
Flipping this to ready-for-review, as I expect the review of this to be basically independent of the review of all the PRs/updates in our dependencies. |
flub
approved these changes
Mar 30, 2026
Contributor
flub
left a comment
flub
left a comment
There was a problem hiding this comment.
you'll need to resolve some conflicts, but no need to net get this merged is there?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
randdependency to version 0.10.As part of that, this also updates
rand_core,rand_chacha, and a bunch of cryptography crates likecurve25519-dalek,ed25519-dalek,digest,sha1andsha2. Some of the latter ones to prerelease versions to enable compilation.Breaking Changes
iroh::SecretKey::generate'sCryptoRngparameter is now updated from rand 0.9 to rand 0.10Notes & open questions
Although this is ready for review, it's not ready to be merged yet, because of patched dependencies.
This is the current TODO list:
fastbloom needs to update to rand 0.10 and make a new release: Update to rand version 0.10 tomtomwombat/fastbloom#27(we can just disable fastbloom's rand feature)Change checklist