Draft
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3999/docs/iroh/ Last updated: 2026-03-24T09:07:54Z |
rklaehn
force-pushed
the
espidf-support
branch
3 times, most recently
from
c7fc42f to
07e970e
Compare
matheus23
reviewed
Mar 12, 2026
Member
There was a problem hiding this comment.
Cool stuff.
With #3992 you won't need the HMAC stuff, and you could instead use XChaCha20 and use the incoming nonce to encrypt the token frames (i.e. use it for the HandshakeTokenKey, that trait changed in that PR). This works without compromises because XChaCha20 has big enough nonces to allow random-choice nonces.
rklaehn
force-pushed
the
espidf-support
branch
3 times, most recently
from
28ebf99 to
b9c5391
Compare
This allows us to disable captive portal checks and https probes on esp32
Make ring optional, allow pure-Rust crypto providers, and relax TLS requirements for constrained targets.
It is just a http request, so in princpile we could even do it via tcp. But we need hyper anyway for other things I think.
The downside is that we have 1 more box for each lookup_ipv6 or lookup_ipv4, but I doubt that it matters. The upside is that hickory will be easier to feature gate later. And it's less code.
feature gate maze...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A lot of ugly hacks to get esp32 to work. We will try to get this much smaller...
This isn't meant to be merged. It's a playground from which we will take isolated PRs to main until there is nothing left to do.
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme