Use nextest profiles instead of cfgs#4059
Closed
matheus23 wants to merge 1 commit intoFrando/netsimfrom
Closed
Conversation
3 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4059/docs/iroh/ Last updated: 2026-03-30T10:36:02Z |
flub
reviewed
Mar 30, 2026
| threads-required = 32 | ||
|
|
||
| [profile.default] | ||
| default-filter = 'not binary(patchbay)' |
Contributor
There was a problem hiding this comment.
What's the tradeoff between profile.default and profile.default.overrides?
Member
Author
There was a problem hiding this comment.
I think they do different things.
The [[profile.default.overrides]] specifies a filter for which tests to apply the override to, not a filter for which tests to run by default.
Frando
added a commit
that referenced
this pull request
Mar 30, 2026
Member
|
Thanks! I merged this onto #3986 manually (had some conflicts because I did some similar changes myself, so hand-merged it). |
Frando
added a commit
that referenced
this pull request
Mar 30, 2026
Frando
added a commit
that referenced
this pull request
Mar 30, 2026
Frando
added a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
patchbay_testcfg in favor of a nextest profile calledpatchbay, and disabling patchbay by default incargo nextestruns.