wip: Move EndpointInfo and friends to iroh-dns#4094
Draft
rklaehn wants to merge 12 commits intoinline-pkarrfrom
Draft
wip: Move EndpointInfo and friends to iroh-dns#4094rklaehn wants to merge 12 commits intoinline-pkarrfrom
rklaehn wants to merge 12 commits intoinline-pkarrfrom
Conversation
This allows some more things to be come private and avoids an Ext trait.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4094/docs/iroh/ Last updated: 2026-04-13T12:30:20Z |
I think this is worth it. It means no more stupid Ext trait or free functions. And like it or not, z32 is used by multiple discovery providers that we support. The cost is just 1. a compile time dependency on data-encoding-macro 2. 256+32 bytes of static data No allocation, no locks, unlike before.
rklaehn
force-pushed
the
move-relay-dns-to-dns
branch
from
33bc0db to
8985654
Compare
rklaehn
force-pushed
the
move-relay-dns-to-dns
branch
from
6d36656 to
6e226d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As suggested by @Frando: move more dns related stuff from iroh-relay to iroh-dns.
Builds on top of #4026
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme