fix(iroh-relay): implement connection accept rate limiting#4102
Open
emrul wants to merge 1 commit inton0-computer:mainfrom
Open
fix(iroh-relay): implement connection accept rate limiting#4102emrul wants to merge 1 commit inton0-computer:mainfrom
emrul wants to merge 1 commit inton0-computer:mainfrom
Conversation
The accept_conn_limit and accept_conn_burst fields on Limits were defined but not implemented (marked with a TODO). This left the relay server vulnerable to connection flooding: an attacker could open thousands of TCP connections that each hold resources for up to 30 seconds (the establish timeout), exhausting file descriptors and memory. Implement a token bucket rate limiter in the accept loop. When configured, incoming connections that exceed the rate are immediately dropped before a handler task is spawned. The bucket refills at accept_conn_limit tokens per second and allows bursts up to accept_conn_burst.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
accept_conn_limitandaccept_conn_burstfields onLimitswere defined but not implemented (marked with a TODO). This left the relay server vulnerable to connection flooding: an attacker could open thousands of TCP connections that each hold resources for up to 30 seconds (the establish timeout), exhausting file descriptors and memory.Implements a token bucket rate limiter in the accept loop. When configured, incoming connections that exceed the rate are immediately dropped before a handler task is spawned. The bucket refills at
accept_conn_limittokens per second and allows bursts up toaccept_conn_burst.Test plan
cargo check -p iroh-relayclean