feat(iroh): do not advertise deprecated IPv6 addrs#4106
Open
dignifiedquire wants to merge 2 commits intomainfrom
Open
feat(iroh): do not advertise deprecated IPv6 addrs#4106dignifiedquire wants to merge 2 commits intomainfrom
dignifiedquire wants to merge 2 commits intomainfrom
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4106/docs/iroh/ Last updated: 2026-04-13T10:03:12Z |
flub
reviewed
Apr 13, 2026
| if !bound.ip().is_unspecified() { | ||
| addrs.entry(local).or_insert(DirectAddrType::Local); | ||
| let flags = find_flags(&netmon_state, local.ip()); | ||
| addrs.entry(local).or_insert((DirectAddrType::Local, flags)); |
Contributor
There was a problem hiding this comment.
Would it be simpler to use DirectAddrType::LocalDeprecated or something? Of will that be too limiting quickly? I'm not very familiar with these flags so not sure what else they capture.
Contributor
Author
There was a problem hiding this comment.
there are potentially more flags, so we could do this, but currently the type is much more like a source, so not sure I want to add something like flags to it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This skips advertising
deprecatedIPv6 addresses in nat traversal, as they are not supposed to be used for new connections.Fixes #4071
Breaking Changes
None
Notes & open questions