chore(ci): drop log level on patchbay#4110
Merged
Frando merged 1 commit intodeps/patchbay-updatefrom Apr 13, 2026
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4110/docs/iroh/ Last updated: 2026-04-13T20:23:44Z |
Frando
reviewed
Apr 13, 2026
| env: | ||
| PATCHBAY_LOG: trace | ||
| RUST_LOG: trace | ||
| PATCHBAY_LOG: ${{ runner.debug && 'trace' || 'debug' }} |
Member
There was a problem hiding this comment.
if we get it stable, I'd prefer to leave PATCHBAY_LOG at trace always. But "rerun with debug output" is fine too. But we can demote it for now.
(PATCHBAY_LOG is the log level at which logs from tasks running on devices in the lab are written to files, it should not affect the terminal output at all. It definitely has a perf impact, but having trace logs always available is nice too)
Frando
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
Notes & open questions
Change checklist
quic-rpciroh-gossipiroh-blobsdumbpipesendme