freebsd.rs: fix build on powerpc64* and riscv64#159
Closed
pkubaj wants to merge 1 commit into
Closed
Conversation
The values in that file apply also on powerpc64* and should work on riscv64 as well. Tested on powerpc64le.
rklaehn
reviewed
Jun 15, 2026
| // Hardcoded based on the generated values here: https://cs.opensource.google/go/x/net/+/master:route/zsys_freebsd_arm.go | ||
| #[cfg(target_arch = "aarch64")] | ||
| #[cfg(any(target_arch = "aarch64", target_arch = "powerpc64", target_arch = "riscv64"))] | ||
| pub use self::arm64::*; |
Contributor
There was a problem hiding this comment.
The arm64 module name now seems inappropriate. Otherwise this seems pretty uncontroversial. But fmt check is failing.
rklaehn
added a commit
that referenced
this pull request
Jun 15, 2026
## Description Add support for powerpc64 and riscv64. See #159 ## Breaking Changes None ## Notes & open questions Note: we rename the module from arm64 to lp64 so it is clear that this now covers more than one arch. Note: it seems at first glance that the amd64 module is identical, it could be removed and also covered by the lp64 module. But we will do this in a subsequent PR.
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The values in that file apply also on powerpc64* and should work on riscv64 as well. Tested on powerpc64le.
Breaking Changes
None
Notes & open questions
None
Change checklist