refactor(netwatch)!: improve platform feature-gating and don't reexport netdev types#163
Draft
Frando wants to merge 1 commit into
Draft
refactor(netwatch)!: improve platform feature-gating and don't reexport netdev types#163Frando wants to merge 1 commit into
Frando wants to merge 1 commit into
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/163/docs/net_tools/ Last updated: 2026-06-15T10:16:56Z |
Frando
force-pushed
the
Frando/refactor-platform-impls
branch
from
ac13c84 to
86ded18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We currently reexport items from
netdevon platforms supported bynetdev, and recreate identical types on other platforms. This is brittle and easy to break.We also relied on module-path-rewriting, which is hard to follow and easy to miss.
This PR fixes both by restructuring the platform impl. It now defines shared types in one place, and then delegates to platform impls in a very normal way. The platforms using netdev still share code, but we no longer re-export any types from netdev.
Also adds a
check-external-typesCI check to validate this.Breaking Changes
Notes & open questions
Change checklist