fix(netwatch): ignore transient recv errors#166
Merged
Conversation
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/net-tools/pr/166/docs/net_tools/ Last updated: 2026-06-16T10:10:30Z |
flub
approved these changes
Jun 16, 2026
Contributor
|
very nice
Yes to setting this socket option. There's no point in wasting the syscalls to read this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On Windows,
UdpSocket::recvcan return an error if the previous send operation on that socket failed with an ICMP error.The error either surfaces as
WSAECONNRESET, which the Rust standard library converts into aio::ErrorKind::ConnectionReset, or as aWSAENETRESET, which becomesErrorKind::Uncategorized.WSAECONNRESETis emitted if the previous send failed due to a ICMP port unreachable, andWSAENETRESETif the previous send got a TTL expired (I think, not sure exactly).Both of these errors are transient, because they are issued max. once per sent datagram. The next recv on the socket then returns either a datagram, a different error, or WouldBlock.
This PR changes the behavior such that we ignore these errors.
It comes with a regression test (first commit). I confirmed that it fails on windows without the fix in the second commit.
Fixes n0-computer/iroh#4297
Fixes n0-computer/iroh-gossip#149
Also tested in n0-computer/iroh#4348
Breaking Changes
None
Notes & open questions
We can and likely should set the
SIO_UDP_CONNRESETsocket option on the underlying socket, which supresses at least theWSAECONNRESETerror altogether. This would need to happen innoq_udpthough. And even if we did it, it's still better to also ignore these errors here IMO.Change checklist