Skip to content

chore(deps): try bumping awc-lc-rs to make cargo deny happy#530

Closed
flub wants to merge 3 commits into
mainfrom
flub/upgrade-aws-lc-rs-cargo-deny
Closed

chore(deps): try bumping awc-lc-rs to make cargo deny happy#530
flub wants to merge 3 commits into
mainfrom
flub/upgrade-aws-lc-rs-cargo-deny

Conversation

@flub
Copy link
Copy Markdown
Collaborator

@flub flub commented Mar 23, 2026

Description

A bunch of security vulnerabilities seem to be released.

Breaking Changes

n/a

Notes & open questions

n/a

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 23, 2026

Performance Comparison Report

a089d14319ebc6172d1c3be3a5e60d322dc32d07 - artifacts

No results available

---
75c80c846c8a358ea58e0a77c404429148cd537c - artifacts

Netsim Benchmarks (network simulation)

Condition noq upstream Delta
ideal 2919.0 Mbps N/A N/A
lan 782.5 Mbps N/A N/A
---
742d6cd5bc97b970aa8f7a76277462c1753beeef - artifacts

Raw Benchmarks (localhost)

Scenario noq upstream Delta CPU (avg/max)
large-single 5755.6 Mbps 7835.3 Mbps -26.5% 96.0% / 107.0%
medium-concurrent 5654.4 Mbps 7800.2 Mbps -27.5% 96.3% / 105.0%
medium-single 3956.8 Mbps 4589.0 Mbps -13.8% 88.9% / 97.2%
small-concurrent 3907.7 Mbps 5092.5 Mbps -23.3% 101.7% / 165.0%
small-single 3593.0 Mbps 4791.0 Mbps -25.0% 96.1% / 112.0%

Netsim Benchmarks (network simulation)

Condition noq upstream Delta
ideal 3156.3 Mbps 4034.8 Mbps -21.8%
lan 782.4 Mbps 810.3 Mbps -3.4%
lossy 69.8 Mbps 55.9 Mbps +25.0%
wan 83.8 Mbps 83.8 Mbps ~0%

Summary

noq is 23.2% slower on average

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 23, 2026

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/530/docs/noq/

Last updated: 2026-03-23T10:19:59Z

@n0bot n0bot Bot added this to iroh Mar 23, 2026
@github-project-automation github-project-automation Bot moved this to 🚑 Needs Triage in iroh Mar 23, 2026
@matheus23
Copy link
Copy Markdown
Member

This work duplicates parts of #511

@flub
Copy link
Copy Markdown
Collaborator Author

flub commented Mar 23, 2026

fixed in #511

@flub flub closed this Mar 23, 2026
@github-project-automation github-project-automation Bot moved this from 🚑 Needs Triage to ✅ Done in iroh Mar 23, 2026
@flub flub deleted the flub/upgrade-aws-lc-rs-cargo-deny branch April 23, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

3 participants