refactor(tests): Replace trait SubNetRouter with an enum, remove Mutex from EimAdfNat#679
Draft
matheus23 wants to merge 2 commits into
Draft
refactor(tests): Replace trait SubNetRouter with an enum, remove Mutex from EimAdfNat#679matheus23 wants to merge 2 commits into
trait SubNetRouter with an enum, remove Mutex from EimAdfNat#679matheus23 wants to merge 2 commits into
Conversation
4 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/noq/pr/679/docs/noq/ Last updated: 2026-05-29T14:21:19Z |
Performance Comparison Report
|
| Scenario | noq | upstream | Delta | CPU (avg/max) |
|---|---|---|---|---|
| large-single | 5404.2 Mbps | 7915.1 Mbps | -31.7% | 94.6% / 100.0% |
| medium-concurrent | 5296.5 Mbps | 7784.2 Mbps | -32.0% | 95.2% / 149.0% |
| medium-single | 3816.7 Mbps | 4749.5 Mbps | -19.6% | 95.2% / 151.0% |
| small-concurrent | 3806.7 Mbps | 5295.7 Mbps | -28.1% | 91.2% / 99.4% |
| small-single | 3438.5 Mbps | 4754.9 Mbps | -27.7% | 90.0% / 97.8% |
Netsim Benchmarks (network simulation)
| Condition | noq | upstream | Delta |
|---|---|---|---|
| ideal | 3045.0 Mbps | 3980.9 Mbps | -23.5% |
| lan | 782.4 Mbps | 810.3 Mbps | -3.4% |
| lossy | 55.9 Mbps | 69.8 Mbps | -20.0% |
| wan | 83.8 Mbps | 83.8 Mbps | ~0% |
Summary
noq is 27.4% slower on average
Collaborator
|
Yeah, this occurred to me too. Didn't like it much. What I did think might be worth exploring is adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Happy to report I was able to just instruct Qwen3.6-36b-a3b locally and it produced the first commit. I reviewed it and fixed up one thing in the second commit.
Anyhow! This is a small refactor get rid of the
MutexinEimAdfNat. Not sure if it's worth doing, because it makes the call sites comparatively worse for.qad_addr().Breaking Changes
Notes & open questions
Change checklist