Team Viewer Role & RBAC Improvements #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thokra-nav
reviewed
Jan 19, 2026
thokra-nav
reviewed
Jan 19, 2026
thokra-nav
reviewed
Jan 19, 2026
thokra-nav
approved these changes
Jan 21, 2026
Contributor
thokra-nav
left a comment
thokra-nav
left a comment
There was a problem hiding this comment.
Approver for å gjøre graphql review grønn, men se over kommentarene
Comment on lines
105
to
119
| -- name: UserIsMember :one | ||
| -- name: ViewerIsMember :one | ||
| SELECT | ||
| EXISTS ( | ||
| SELECT | ||
| id | ||
| FROM | ||
| user_roles | ||
| WHERE | ||
| user_id = @user_id | ||
| AND target_team_slug = @team_slug::slug | ||
| AND role_name IN ('Team member', 'Team owner') | ||
| ) | ||
| ; | ||
|
|
||
| -- name: UserIsOwner :one |
Contributor
There was a problem hiding this comment.
Synes vi kan fortsette å kalle disse UserIs..
internal/team/queries.go
Outdated
Comment on lines
455
to
463
| func ViewerIsOwner(ctx context.Context, teamSlug slug.Slug, userID uuid.UUID) (bool, error) { | ||
| return db(ctx).ViewerIsOwner(ctx, teamsql.ViewerIsOwnerParams{ | ||
| UserID: userID, | ||
| TeamSlug: teamSlug, | ||
| }) | ||
| } | ||
|
|
||
| func UserIsMember(ctx context.Context, teamSlug slug.Slug, userID uuid.UUID) (bool, error) { | ||
| return db(ctx).UserIsMember(ctx, teamsql.UserIsMemberParams{ | ||
| func ViewerIsMember(ctx context.Context, teamSlug slug.Slug, userID uuid.UUID) (bool, error) { | ||
| return db(ctx).ViewerIsMember(ctx, teamsql.ViewerIsMemberParams{ |
Contributor
There was a problem hiding this comment.
Her også, bedre å beholde UserIs... navnene
Co-authored-by: Johnny Horvi <johnny@horvi.no>
Co-authored-by: Johnny Horvi <johnny@horvi.no>
Changed from RFC3339 annotation to Unix timestamp label for consistency with naiserator webhook and euthanaisa.
Refactor secret loader to use impersonated clients for all operations. Remove ServiceAccountClientCreator and related methods. Update secret queries to use watcher.ImpersonatedClient and watcher.Delete.
frodesundby
force-pushed
the
envmapping
branch
from
3917955 to
4e3e41d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes
🔑 Secret Metadata Without Elevation
Secret.keysfield to expose key names without requiring elevation🔄 Secret Client Refactoring
ServiceAccountClientCreatorabstractionSystemAuthenticatedClient(service account)ImpersonatedClient(user elevation)🧹 Cleanup