[3/4] Optionally use a fixed window size instead of 0.1 of the read length#36
Open
tsibley wants to merge 7 commits intonajoshi:masterfrom
Open
[3/4] Optionally use a fixed window size instead of 0.1 of the read length#36tsibley wants to merge 7 commits intonajoshi:masterfrom
tsibley wants to merge 7 commits intonajoshi:masterfrom
Conversation
Standardizes on --truncate-n. This preserves the --trunc-n long name previously mentioned in the SE usage. It removes the --discard-n long name only ever used internally, but never documented.
This will help keep them in sync when updating options.
No functional change, only whitespace (compare with git diff -w).
The usage docs now indicate option arguments and are easier to read. If the usage was specifically requested with --help, then it is printed to stdout instead of stderr. This is useful for the common idiom of asking for help and piping to a pager like less or more (without redirecting stderr).
Silences warnings about //-style comments and long strings. Since kseq.h uses inline functions, a feature of C99, it's not useful pretending to be C89 compat (GCC's default).
A fixed window size provides a stricter control on average base qualities for datasets with a wide range of read lengths.
tsibley
force-pushed
the
fixed-window
branch
from
0425b63 to
6597584
Compare
Author
tsibley
changed the title
Author
|
@xapple That's up to @najoshi, who seems to be pretty out of touch with the Github issues/PRs. You can always use the @MullinsLab sickle fork if you want, which does have this PR merged into it. |
|
OK That's cool, maybe I'll try it out. But if you have forked and added features etc. you should definitely bump the version number and have sickle 1.34 |
Author
|
No, I'm not going to version our fork in the same space as @najoshi's. That would lead to much confusion. I did change how the version is displayed, however: MullinsLab@4b0dc85 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fixed window size provides a stricter control on average base qualities for datasets with a wide range of read lengths.
Note: this depends on my previous branch (PR #34) and so contains those commits as well. Only the tip commit is the feature-adding one.