Skip to content

feat: display the file currently being debugged in the title bar.#118

Open
s4my wants to merge 1 commit intonakst:masterfrom
s4my:master
Open

feat: display the file currently being debugged in the title bar.#118
s4my wants to merge 1 commit intonakst:masterfrom
s4my:master

Conversation

@s4my
Copy link
Copy Markdown
Contributor

@s4my s4my commented Sep 4, 2023

display the file currently being debugged in the title bar, as requested by #117.

@s4my
Copy link
Copy Markdown
Contributor Author

s4my commented Sep 9, 2023

@nakst i would like any feedback, if you want me to change anything, please feel free to say so.

@nakst
Copy link
Copy Markdown
Owner

nakst commented Sep 9, 2023

The reason I haven't merged this pull request is because the current file name is already displayed in the console window and the stack backtrace window. But I'm happy to leave the pull request open here for anyone that wants to apply the patch themselves regardless.

@s4my
Copy link
Copy Markdown
Contributor Author

s4my commented Sep 9, 2023

I see, you should of said that in the issue #117, i was left in the dark, i couldn't of guessed that.
And btw what does the label skill issue mean? you forgot to set it's description in https://github.com/nakst/gf/labels

@nakst
Copy link
Copy Markdown
Owner

nakst commented Sep 9, 2023

And btw what does the label skill issue mean?

Sorry, it's a joke.

@s4my s4my force-pushed the master branch 3 times, most recently from 2e9afcb to 90c64f7 Compare September 17, 2023 04:30
@s4my s4my force-pushed the master branch 3 times, most recently from 141e685 to eef9eaf Compare September 25, 2023 18:57
@s4my s4my force-pushed the master branch 6 times, most recently from c30823d to 9620f4b Compare October 1, 2023 19:06
@s4my s4my force-pushed the master branch 4 times, most recently from 9b4912c to 5857f7c Compare October 11, 2023 20:13
@s4my s4my force-pushed the master branch 4 times, most recently from 8e2c0b3 to c88e440 Compare October 21, 2023 00:47
@s4my s4my force-pushed the master branch 2 times, most recently from 03101da to 6e29c48 Compare October 27, 2023 19:29
@s4my s4my force-pushed the master branch 2 times, most recently from 5ec29cb to f1307b5 Compare October 31, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants