This repository was archived by the owner on Jan 31, 2026. It is now read-only.
Document haptic timing constants with rationale and performance tradeoffs#17
Closed
Copilot wants to merge 3 commits intobug/thread-not-startedfrom
Closed
Document haptic timing constants with rationale and performance tradeoffs#17Copilot wants to merge 3 commits intobug/thread-not-startedfrom
Copilot wants to merge 3 commits intobug/thread-not-startedfrom
Conversation
Co-authored-by: nalathethird <36301692+nalathethird@users.noreply.github.com>
Co-authored-by: nalathethird <36301692+nalathethird@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP to address feedback on bHapticsManager architecture
Document haptic timing constants with rationale and performance tradeoffs
Nov 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on PR #8 regarding undocumented magic numbers for haptic timing parameters.
Changes
UPDATE_INTERVAL_MS (8ms): Documents reduction from 10ms → 8ms (100 Hz → 125 Hz) for improved temporal resolution in fast-changing haptic effects (vibration, pain pulses)
SUBMISSION_DURATION_MS (100ms): Documents increase from 40ms → 100ms to maintain 12.5x frame overlap, preventing perceptible gaps while balancing responsiveness to rapid intensity changes
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.