This repository was archived by the owner on Jan 31, 2026. It is now read-only.
Fix race condition in BHapticsConnection.Initialize()#18
Closed
Copilot wants to merge 2 commits intobug/thread-not-startedfrom
Closed
Fix race condition in BHapticsConnection.Initialize()#18Copilot wants to merge 2 commits intobug/thread-not-startedfrom
Copilot wants to merge 2 commits intobug/thread-not-startedfrom
Conversation
Co-authored-by: nalathethird <36301692+nalathethird@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update architecture for bHapticsManager based on review feedback
Fix race condition in BHapticsConnection.Initialize()
Nov 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Initialize()method checked_isInitializedwithout synchronization, allowing concurrent threads to pass the guard simultaneously and attempt multiple initializations.Changes
_initializeLockto serialize initialization and shutdownInitialize()method body in lock to prevent concurrent initialization attempts_isInitializedwrite inShutdown()with same lock✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.