Narrative Overhaul: reserve top-level package names #1800
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # enscli | ||
|
|
||
| This package name is reserved for the [ENSNode](https://ensnode.io) project by [NameHash Labs](https://namehashlabs.org). | ||
|
|
||
| For more information, visit [ensnode.io](https://ensnode.io). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "name": "enscli", | ||
| "version": "0.0.1", | ||
| "description": "Reserved for the ENSNode project by NameHash Labs. See https://ensnode.io", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/namehash/ensnode.git", | ||
| "directory": "packages/enscli" | ||
| }, | ||
| "license": "MIT", | ||
|
Member
There was a problem hiding this comment. Suggest to add the related LICENSE files to each package 👍 |
||
| "homepage": "https://ensnode.io" | ||
| } | ||
|
shrugs marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # enskit | ||
|
|
||
| This package name is reserved for the [ENSNode](https://ensnode.io) project by [NameHash Labs](https://namehashlabs.org). | ||
|
|
||
| For more information, visit [ensnode.io](https://ensnode.io). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "name": "enskit", | ||
| "version": "0.0.1", | ||
| "description": "Reserved for the ENSNode project by NameHash Labs. See https://ensnode.io", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/namehash/ensnode.git", | ||
| "directory": "packages/enskit" | ||
| }, | ||
| "license": "MIT", | ||
| "homepage": "https://ensnode.io" | ||
| } | ||
|
shrugs marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # enssdk | ||
|
|
||
| This package name is reserved for the [ENSNode](https://ensnode.io) project by [NameHash Labs](https://namehashlabs.org). | ||
|
|
||
| For more information, visit [ensnode.io](https://ensnode.io). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "name": "enssdk", | ||
| "version": "0.0.1", | ||
| "description": "Reserved for the ENSNode project by NameHash Labs. See https://ensnode.io", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/namehash/ensnode.git", | ||
| "directory": "packages/enssdk" | ||
| }, | ||
| "license": "MIT", | ||
| "homepage": "https://ensnode.io" | ||
| } | ||
|
shrugs marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| # ensskills | ||
|
|
||
| This package name is reserved for the [ENSNode](https://ensnode.io) project by [NameHash Labs](https://namehashlabs.org). | ||
|
|
||
| For more information, visit [ensnode.io](https://ensnode.io). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "name": "ensskills", | ||
| "version": "0.0.1", | ||
|
Member
There was a problem hiding this comment. Suggest to initialize all these versions to be in sync with the overall ENSNode version. |
||
| "description": "Reserved for the ENSNode project by NameHash Labs. See https://ensnode.io", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/namehash/ensnode.git", | ||
| "directory": "packages/ensskills" | ||
| }, | ||
| "license": "MIT", | ||
| "homepage": "https://ensnode.io" | ||
| } | ||
|
shrugs marked this conversation as resolved.
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we'll need to update several config files / CI scripts for these new packages to integrate into our changesets / release processes.
Also, FYI: the release processes in our CI are configured to use my personal NPM account token right now (configured as a GitHub Secret). I imagine we might need to do configure something so that my personal NPM account will be able to publish these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, yeah the CI auth scope will have to be considered — my hope is that because the packages are fully managable by developers of the ensnode org, that any developer's access token (i.e. yours) will be able to manage/publish them